Skip to content

Remove inauthentic barcrawl vial smash

Sam requested to merge scholar_nz/2009scape:barcrawl-vial-smash-removal into master

What have you done in this MR?

image

@Ceikry Requires your approval due to changes in core, and could use your insight in terms of authenticity.

Are there any tricky things testers should keep an eye out for?

  • No

For Testers:

Testing scope:

  • Complete barcrawl and drink the last dose of a potion. If you retain an empty vial, the test passes.
  • Barcrawl can be skipped by uploading a save with the correct save information added to your file: "barCrawl": { "started": true, "bars": [ true, true, true, true, true, true, true, true, true, true ] },
  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ryan

Merge request reports