Skip to content

Resolve "Tipping crossbow bolts with a full inv"

Sam requested to merge scholar_nz/2009scape:953-fix-bolt-inventory-logic into master

What have you done in this MR?

  • Added handling for a full inventory state for:

    • Bolt Finishing
    • Tipping Bolts
  • Resolved logic issues for when a player attempts to combine the wrong ingredients.

Testing process I'd forsee for this MR is:

  1. Can not tip with full inv when you don't have the product in your inventory
  2. Can tip with product and a full inventory
  3. Can tip with spaces in your inventory
  4. Can tip only with the correct ingredients. In all other cases, nothing should happen. (i.e diamond tips to rune bolts should not work)

Also, should be able to test similar cases for:

  1. Making bolts (unf) into bolts of any kind

Are there any tricky things testers should keep an eye out for?

  • No * [ ] Yes, as follows: As described above. No other complications seem to be present.

  • I have tested these changes thoroughly.

* [ ] This requires extra testing due to changes to architecture or other similarly risky changes.

* [ ] I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

Closes #953 (closed)

Edited by Sam

Merge request reports