Add Dylan Bernardi as Maintainer: JetBrains Plugin
Why is this change being made?
This change reflects the continued need for maintainers on the editor-extensions team, specifically on the JetBrains codebase. By adding myself as a maintainer it greatly enhances the team's value by improving our ability to review and release outstanding features more quickly and efficiently.
Basic setup
-
Create a merge request for trainee_maintainer
: Add Dylan Bernardi as Trainee Maintainer: JetBr... (!134189 - merged) -
Join the #f_jetbrains_plugin
Slack channel. -
Read and understand the maintainer responsibilities for this project. -
Browse through the development resources to get an idea of how the plugin works. -
Open a merge request to improve the documentation or Maintainer Onboarding template. -
Optional: Pair with a maintainer to review a merge request or implement a small change. -
Optional: Read the code review page in the handbook and the code review guidelines. -
Optional: Understand how to become a maintainer.
Code Review Pairing
Much like pair programming, pairing on code review is a great way to knowledge share and collaborate on merge request. This is a great activity for trainee maintainers to participate with maintainers for learning their process of code review.
A private code review session (unrecorded) involves one primary reviewer, and a shadow. If more than one shadow wishes to observe a private session, please consider obtaining consent from the merge request author.
A public code review session involves a primary reviewer and one or more shadows in a recorded session that is released publicly, for example to GitLab Unfiltered.
- If the merge request author is a GitLab team member, please consider obtaining consent from them.
- If the merge request author is a community contributor, you must obtain consent from them.
- Do not release reviews of security merge requests publicly.
When you're ready to make it official
When reviews have accumulated, you can confidently address the majority of the MR's assigned to you, and recent reviews consistently fulfill maintainer responsibilities, then you can propose yourself as a new maintainer for the relevant application.
Remember that even when you are a maintainer, you can still request help from other maintainers if you come across an MR that you feel is too complex or requires a second opinion.
If you need assistance with any of the following steps, ask in either the #g_editor-extensions
or #f_jetbrains_plugin
Slack channel.
-
Create a merge request updating your team member entry proposing yourself as a maintainer for the gitlab-jetbrains-plugin
project, assigned to your manager. -
Ask an existing maintainer to give you the Maintainer role in this GitLab project. -
Get Developer access to the plugin's JetBrains Marketplace listing. -
Get added to the jetbrains@gitlab.com
Google group. -
Get added to the JetBrains Plugin
1Password vault. -
Keep reviewing, start merging 🤘
Author and Reviewer Checklist
Please verify the check list and ensure to tick them off before the MR is merged.
-
Provided a concise title for this Merge Request (MR) -
Added a description to this MR explaining the reasons for the proposed change, per say why, not just what - Copy/paste the Slack conversation to document it for later, or upload screenshots. Verify that no confidential data is added, and the content is SAFE
-
Assign reviewers for this MR to the correct Directly Responsible Individual/s (DRI) - If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
Maintained by
section on the page being edited - If your manager does not have merge rights, please ask someone to merge it AFTER it has been approved by your manager in #mr-buddies
- The when to get approval handbook section explains the workflow in more detail
- If the DRI for the page/s being updated isn’t immediately clear, then assign it to one of the people listed in the
-
For transparency, share this MR with the audience that will be impacted. -
Team: For changes that affect your direct team, share in your group Slack channel -
Department: If the update affects your department, share the MR in your department Slack channel -
Company: If the update affects all (or the majority of) GitLab team members, post an update in #whats-happening-at-gitlab linking to this MR - For high-priority company-wide announcements work with the internal communications team to post the update in #company-fyi and align on a plan to circulate in additional channels like the "While You Were Iterating" Newsletter
-
Commits
- Add maintainer to team page for JetBrains Plugin