Skip to content
GitLab
Menu
Why GitLab
Pricing
Contact Sales
Explore
Why GitLab
Pricing
Contact Sales
Explore
Sign in
Get free trial
Commits on Source (2)
(fix) add username to string in base model
· 4bf87f0b
Juan Manuel Solaro
authored
Dec 09, 2019
and
Brian Hatchet
committed
Dec 09, 2019
4bf87f0b
Merge branch 'fix-username-touppercase-not-a-function' into 'release/3.12.1'
· 79d0fc78
Brian Hatchet
authored
Dec 09, 2019
(fix) add username to string in base model See merge request
!444
79d0fc78
Hide whitespace changes
Inline
Side-by-side
src/common/BaseModel.js
View file @
79d0fc78
...
...
@@ -81,6 +81,11 @@ export default class BaseModel {
constructor
(
data
)
{
Object
.
assign
(
this
,
data
);
// Some users have a number as username and engine return them as a number
if
(
this
.
username
)
{
this
.
username
=
this
.
username
.
toString
();
}
// create childs instances
const
childs
=
this
.
childModels
()
for
(
var
prop
in
childs
)
{
...
...
src/messenger/conversation/ConversationView.js
View file @
79d0fc78
...
...
@@ -38,11 +38,6 @@ export default class ConversationView extends Component {
let
unread
=
item
.
unread
?
<
Icon
style
=
{
styles
.
icons
}
name
=
'
md-notifications
'
color
=
'
#4caf50
'
size
=
{
19
}
/> : null
;
let
online
=
item
.
online
?
<
Icon
style
=
{
styles
.
icons
}
name
=
'
md-radio-button-on
'
color
=
'
#2196f3
'
size
=
{
19
}
/> : null
;
// Added to capture information about /issues/1203549247/?project=1538735
if
(
item
.
username
&&
!
item
.
username
.
toUpperCase
)
{
Sentry
.
captureMessage
(
'
ISSUE 1203549247 No username on
'
+
item
.
guid
+
'
name:
'
+
item
.
name
);
}
return
(
<
TouchableOpacity
style
=
{
styles
.
row
}
onPress
=
{
this
.
_navToConversation
}
>
<
Image
source
=
{
avatarImg
}
style
=
{
styles
.
avatar
}
/
>
...
...