Skip to content
Snippets Groups Projects

Added find group button to sidebar #2379

Merged Ben requested to merge feat/find-group-button-2379 into master

Summary

Closes #2379 (closed)

3 things

  • Add a Find a Group button to the groups sidebar linking to discovery.
  • Make Cypress login a data attribute in Cypress
  • Fixes a 1px misalignment for icons (the + and Find a Group)in the groups sidebar.

Steps to test

Simple one,

  1. Log in
  2. Click new button on sidebar
  3. Check URL is correct

I've tested this with more than 12 groups.

image

Estimated Regression Scope

Not a huge change, not much scope for regression but I'd check the sidebar still functions as intended and the discovery URL is correct.

Merge request reports

Checking pipeline status.

Merged by Xander MillerXander Miller 5 years ago (Jan 21, 2020 4:58pm UTC)

Merge details

Pipeline #111161121 waiting for manual action

Pipeline waiting for manual action for 2cc0aeda on master

4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Emiliano Balbuena added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • assigned to @benhayward.ben and unassigned @edgebal

  • mentioned in issue #2379 (closed)

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Emiliano Balbuena added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Emiliano Balbuena approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading