Modal pager
Summary
Go back and forth on images/videos/blogs for the current user or group on media modal.
Closes #1737 (closed). Depends engine!437 (merged)
Steps to test
- Visit https://epic-modal-pager.minds.io/0xemi/. Arrows will appear in the main view to allow going back and forth all user's media.
- Log in with your user
- Post 2 or more images or blogs (video transcoder seems to be down for review sites)
- Click one of them, you should be able to go back and forth using the arrows (keyboard/on-screen element)
- Test that you are able to close the media modal using Esc key.
- Test that when you use the keyboard arrows on text fields (i.e. the comment input) it doesn't trigger the navigation
- Go to a group (or create a new one), copy the URL
- Post a couple of images
- Login with another user (or create a new one)
- Go to the group and join it
- Post a couple of images
- Test that you can go back and forth all groups images on the media modal.
Estimated Regression Scope
- Media modal entity loading
- Media modal media sizing
- Media modal permalink URLs
Merge request reports
Activity
mentioned in merge request engine!437 (merged)
Excited for this @edgebal :)
added 1 commit
- e6fe8635 - (feat): Keyboard navigation + esc key handling
added 1 commit
- a8729b07 - (feat): Change dimensions on-the-fly when video metadata is loaded
added 10 commits
-
3a92f989...1c8ee565 - 8 commits from branch
master - d6e85f23 - Merge remote-tracking branch 'origin/master' into epic/modal-pager
- a0cf2bb6 - (refactor): ditch redirectUrl and handle URL hot-swap on modal
-
3a92f989...1c8ee565 - 8 commits from branch
assigned to @benhayward.ben
added 6 commits
-
a0cf2bb6...1181bc82 - 4 commits from branch
master - e26eefec - Merge remote-tracking branch 'origin/master' into epic/modal-pager
- bd72b1f8 - (chore): JSdoc
-
a0cf2bb6...1181bc82 - 4 commits from branch
Works as intended by my tests. Will approve but a few things to mention.
- The arrows are real small for my tastes; I don't know whether making them bigger would make it more aesthetically pleasing, but they don't stand out very much.
- Perhaps because of point 1 I feel there's not much feedback to the user when you hit the end.
- Should it be infinite?
cc: @brianhatchet
Making the arrows bigger won't help because they are completely invisible on some posts. eg.
Arrows should have a partially transparent black background color circle behind them to make them visible on all posts. I would recommend something with some like 80% opacity black so there is always contrast with the arrows.
Edited by Xander Miller
assigned to @xander-miller and unassigned @benhayward.ben
