Skip to content
Snippets Groups Projects

Reintroduced maturity selector for activity comments. #2392

Merged Ben requested to merge fix/explicit-comments-2392 into master

Summary

Closes #2392 (closed)

I've re-enabled the maturity filter for comments here, in the same style as we handle it in activities.

Steps to test

Note: if you are the owner, your text is in the show state by default.

  1. Login.
  2. post a non-mature comment on a post.
  3. post a mature comment.
  4. Repeat steps 2 and 3, nesting into the comment tree so that you have 3 tiers of mature and non-mature comments.
  5. Refresh, the posts, they should all be visible as you are the logged-in user.
  6. You should be able to click on the red E icon to blur mature the posts.
  7. Copy the link to the post.

Then,

  1. Log out
  2. Go to the post you made above.
  3. Check the mature text is all blurred.
  4. Click on the text, not the E button to ensure it gets rid of the blur,
  5. Click the text again, it should do nothing.
  6. Click the button again, it should re-blur.
  7. Cycle the button on and off to check it works properly.

Estimated Regression Scope

This change effects comments.

The html-template changes should be self-contained; I don't think they'd affect anything outside of their lines of code by themselves, the only bit of code that really touched anything is in the ngOnInit(), where I check the users guid, and set the content to show if they are the owner of the comment. So, as a worst-case scenario, maybe it would show by default for everybody.

Edited by Ben

Merge request reports

Checking pipeline status.

Merged by Brian HatchetBrian Hatchet 5 years ago (Jan 10, 2020 4:10pm UTC)

Loading

Pipeline #108451163 waiting for manual action

Pipeline waiting for manual action for 253d61a7 on master

Deployed to pre‎prod‎ 5 years ago
Deployed to can‎ary‎ 5 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading