Group membership change propegation
All threads resolved!
All threads resolved!
Summary
Closes #2228 (closed)
This MR makes it so that when joining, leaving, creating and destroying a group, the sidebar updates without the user having to refresh.
Steps to test
Create and Delete
- Log in.
- Create a new group.
- Check the sidebar has the new group without you having to reload.
- Delete the group, it should now be gone.
Leave and Join
- Join a group that you are not an admin of.
- Leave the group - it should now be gone from the sidebar.
- Rejoin, it should be back.
Estimated Regression Scope
GroupsService, The group sidebar have been the main focus of this change, most of the logical changes are in there.
I've also touched two other areas due to errors flooding my console when testing:
Avatar component, the only change is an extra condition in an if statement, so I don't see much of an issue with that but note it has been touched.
Other than that some changeDetection was added to the videochat component.
Merge request reports
Activity
added StatusRequires Changes + 1 deleted label
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
added 7 commits
-
f0812700...52608901 - 6 commits from branch
master
- 20ca45a7 - Merge branch 'master' of gitlab.com:minds/front into fix/group-membership-propegation-2228
-
f0812700...52608901 - 6 commits from branch
- Resolved by Brian Hatchet
- Resolved by Brian Hatchet
added 1 deleted label and removed StatusRequires Changes label
mentioned in commit df2e25e3
Please register or sign in to reply