Skip to content
Snippets Groups Projects

Group membership change propegation

Merged Ben requested to merge fix/group-membership-propegation-2228 into master
All threads resolved!

Summary

Closes #2228 (closed)

This MR makes it so that when joining, leaving, creating and destroying a group, the sidebar updates without the user having to refresh.

Steps to test

Create and Delete
  1. Log in.
  2. Create a new group.
  3. Check the sidebar has the new group without you having to reload.
  4. Delete the group, it should now be gone.
Leave and Join
  1. Join a group that you are not an admin of.
  2. Leave the group - it should now be gone from the sidebar.
  3. Rejoin, it should be back.

Estimated Regression Scope

GroupsService, The group sidebar have been the main focus of this change, most of the logical changes are in there.

I've also touched two other areas due to errors flooding my console when testing:

Avatar component, the only change is an extra condition in an if statement, so I don't see much of an issue with that but note it has been touched.

Other than that some changeDetection was added to the videochat component.

Merge request reports

Checking pipeline status.

Merged by Xander MillerXander Miller 5 years ago (Jan 9, 2020 6:44pm UTC)

Loading

Pipeline #108200024 waiting for manual action

Pipeline waiting for manual action for df2e25e3 on master

Deployed to pre‎prod‎ 5 years ago
Deployed to can‎ary‎ 5 years ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ben
  • Ben added 7 commits

    added 7 commits

    • f0812700...52608901 - 6 commits from branch master
    • 20ca45a7 - Merge branch 'master' of gitlab.com:minds/front into fix/group-membership-propegation-2228

    Compare with previous version

  • Brian Hatchet
  • Brian Hatchet
  • Ben added 1 commit

    added 1 commit

    • ee302228 - Update sidebar-markers.component.ts

    Compare with previous version

  • Brian Hatchet resolved all threads

    resolved all threads

  • Brian Hatchet approved this merge request

    approved this merge request

  • Brian Hatchet added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Xander Miller approved this merge request

    approved this merge request

  • merged

  • Xander Miller mentioned in commit df2e25e3

    mentioned in commit df2e25e3

  • Please register or sign in to reply
    Loading