Fixed pattern matching for external and internal page links #2133

Summary

Pattern matching for the /p/ pages is broken on production. To replicate, go and click the iOS link in the footer.

Our system is seeing the URL itunes.apple.com/us/app/minds-com/id961771928%3Fmt Seeing that it contains '/p' and thinking that it is an internal page

This happened because the system was looking simply for indexOf('p/')

For this fix I have upgraded that check to a regex check, in a commonly held service.

Steps to test

Ignore the first iPhone link - that is invalid data that for now is trapped in the sandbox. (If there is now only 1 link for iPhone, include it in the test, we may have found the missing schema and fixed).

1. Not logged in, check the links on the bottom footer, ensure they're all working
2. Log in, check the links on the newsfeed footer
3. Check the links on the actual /p/ pages, like https://www.minds.com/p/terms-of-service/
4. Check the pro footer hasn't been effected https://www.minds.com/pro

Estimated Regression Scope

The components touched by this are: Footer, register homepage and newsfeed.

I think the worst-case scenario would be a failure in the Regex logic causing another pattern matching issue.

added StatusRequires Changes + 1 deleted label

added 1 commit

• 6527b1eb - Update footer.component.spec.ts

Compare with previous version

added 2 commits

• 4abf88a3 - Fixed regex issue apparent on sanbox
• 4a17a6f9 - Merge branch 'fix/external-pages-regex-2133' of gitlab.com:minds/front into...

Compare with previous version

Still an issue with that regex.

!702 (diffs)

Seems to be disregarding the starting char ^

added 1 commit

• a06f22a5 - Turned regex.test into path.match(regex) because of weird error

Compare with previous version

added 1 commit

• bbd796c7 - Fixed RexExp issue

Compare with previous version

changed the description

added 1 deleted label and removed StatusRequires Changes label

approved this merge request

Looks good! Internal links seem to be working OK on the sandbox site.

added StatusRequires Changes label and removed 1 deleted label

added 1 commit

• 267e8228 - Simplified RegExp

Compare with previous version

added 1 deleted label and removed StatusRequires Changes label

resolved all threads

assigned to @brianhatchet and @xander-miller

approved this merge request

added StatusReady to Merge label and removed 1 deleted label

Re-tested, working OK on review site.

approved this merge request