Skip to content

[Sprint/RollingRabbit](fix): Swapped out old failing datepicker library

Ben requested to merge fix/date-picker-transactions-2171 into master

Closes #2171 (closed)

Summary

The old date-picker component was broken (the one that is used on the wallet pages as filters). Swapping out other components to use this format is out of the scope of this MR, but would be worth consideration.

https://github.com/DanielYKPan/date-time-picker - Actively maintained, quite a lot of functionality that's easy to reach (e.g. min and max).

image

Testing

  1. Log in, type a post.
  2. Select a value in the date selector to a date in the future.
  3. Close the date window and re-open. it should remember the date when re-opened.
  4. Change the date to today, and the time to 6 minutes in the future.
  5. Type the time in the post
  6. Post it
  7. Check the wallet pages with date filters all work correctly.
  8. Check back in a few minutes, post should have posted and the time posted should match the post text.

Regression Scope

This is quite a big change with a couple of areas a regression could crop up in.

  1. Existing calendars in hidden corners of the site should be compatible with this wrapper, but they could fail.
  2. The time shown and posted times could not be accurate.
Edited by Ben

Merge request reports

Loading