Skip to content
Snippets Groups Projects

[Sprint/RollingRabbit](fix): Blocked channels eternally loading. #2244

Merged Ben requested to merge fix/blocked-channels-bug-2244 into master

Closes #2244 (closed)

Summary

Currently, users on production who have nobody blocked will see an ever-spinning loading icon.

Testing

  • Check /settings/blocked-channels
  • Observe that when channels are blocked, they are shown, when channels are not blocked, the loading icon does not endlessly display.

Reasoning

I'm throwing an error to end the observable lifecycle. The filter with this approach is redundant.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading