Skip to content
Snippets Groups Projects

(feat): Show "log in to comment" when logged out

Merged Emiliano Balbuena requested to merge goal/log-in-notice-comment-thread into master

Testing

Empty comments box

  • Create a new post in the newsfeed and copy the URL
  • Log out and paste the URL
  • A Log in to comment link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up

Threaded comments box

  • (using the post from the previous testing case)
  • Add a comment
  • Reply to that same comment to create a thread
  • Log out and paste the URL
  • A Log in to comment link should show up on the root level
  • Nothing should show up on the thread
  • Click on LOGIN and enter creds
  • Page will be refreshed and comment composer should show up on both root and thread levels

Group conversation

  • Create (or go to) a public group, copy the URL
  • Logout and paste the URL
  • A Log in to send a message link should show up
  • Click on LOGIN and enter creds
  • Page will be refreshed and message composer should show up

Issues

Merge request reports

Checking pipeline status.

Approved by

Merged by Mark HardingMark Harding 5 years ago (Nov 8, 2019 2:10pm UTC)

Merge details

  • Changes merged into master with 9cb3a5b1 (commits were squashed).
  • Deleted the source branch.

Pipeline #94644362 passed

Pipeline passed for 9cb3a5b1 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading