Skip to content
Snippets Groups Projects

[Sprint/QuietQuail](fix): Avatar changing forms now change avatar without refresh of components

Merged Ben requested to merge fix/avatar-change-detection-2197 into master
All threads resolved!

Closes #2197 (closed) #2087 (closed) #1835 (closed) and half of #2082 (closed)

Testing

I think it'd be best to spin this up on a subdomain connected to live data, like revolver; so that it can be tested on the live site.

This makes changes to avatars site-wide, user avatars, and group avatars.

To test:

  1. Create a new account.
  2. Upload an avatar - check it updates everywhere.
  3. Create a comment on a post with current avatar.
  4. Change avatar.
  5. Create a second comment on a post, avatar on all comments should match current avatar of channel.
Edited by Xander Miller

Merge request reports

Checking pipeline status.

Merged by Mark HardingMark Harding 5 years ago (Nov 12, 2019 9:16am UTC)

Merge details

Pipeline #95286643 waiting for manual action

Pipeline waiting for manual action for 9e90087b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 1 commit

    added 1 commit

    • f5118c96 - Refactored and got rid of account switching bug

    Compare with previous version

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Ben resolved all threads

    resolved all threads

  • Ben resolved all threads

    resolved all threads

  • After login, I no longer have an avatar on the topbar Screenshot_2019-11-05_at_10.05.47.

  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Appears to be a change detection issue.

  • Xander Miller mentioned in merge request engine!386 (merged)

    mentioned in merge request engine!386 (merged)

  • Comment avatars should match current avatar not avatar when comment was made.

    image

  • Xander Miller changed the description

    changed the description

  • Ben added 1 commit

    added 1 commit

    • 8871491e - Updated to account for session switching

    Compare with previous version

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben added 64 commits

    added 64 commits

    • e169b919...9cb3a5b1 - 62 commits from branch master
    • 8565bdfa - Merge branch 'master' of gitlab.com:minds/front into fix/avatar-change-detection-2197
    • 7d74b971 - Initialize observable at creation

    Compare with previous version

  • Mark Harding approved this merge request

    approved this merge request

  • merged

  • Mark Harding mentioned in commit 9e90087b

    mentioned in commit 9e90087b

  • Please register or sign in to reply
    Loading