Skip to content
Snippets Groups Projects

[Sprint/QuietQuail](feat) Rich embed open in media modals #2162

Merged Ben requested to merge feat/rich-embed-modals-2162 into master

Summary

Opening youtube videos in modals.

Testing

This has the potential to affect

My test plan (note gifs aren't working at present on sandboxes): Visit: https://feat-rich-embed-modals-2162.minds.io/richembedtest/

  • Click through the content.
  • Test in groups, comments and discovery>latest.
  • Flip the feature flag via helm (any help, let me know).
  • Refresh and check that everything still works

Try a variety of content.

Edited by Ben

Merge request reports

Checking pipeline status.

Merged by Mark HardingMark Harding 5 years ago (Nov 7, 2019 11:16am UTC)

Merge details

Pipeline #94318908 waiting for manual action

Pipeline waiting for manual action for 524d294a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben changed the description

    changed the description

  • Ben added 2 commits

    added 2 commits

    Compare with previous version

  • Ben unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Ben mentioned in issue #2165 (closed)

    mentioned in issue #2165 (closed)

  • Mark Harding
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Looking good so far. The description/title looks to be overflowing (potentially just remove this?).

    Screenshot_2019-11-04_at_09.27.50 https://feat-rich-embed-modals-2162.minds.io/newsfeed/1038021148513669138

  • Ben added 1 commit

    added 1 commit

    • d109f28f - Took out description and title

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading