Skip to content
Snippets Groups Projects

[Sprint/PinkPanther](fix): Upload cancelling #2083

Merged Ben requested to merge fix/upload-cancel-2083 into master
All threads resolved!

Closes #2083 (closed) Credits to Mark for the elegant solution

Summary

Upload cancellation is broken on production. Go upload a video on it and try to cancel it.

Test

  1. Upload a video, & whilst uploading, upload a second video - it should replace the existing upload, progress bar should not jump erratically.
  2. Try cancelling the upload. it should cancel. - Without a refresh, try to upload a second video.
  3. Uploading a video should complete all the way and post.
  4. Should not interfere with image upload.
Edited by Ben

Merge request reports

Checking pipeline status.

Merged by Mark HardingMark Harding 5 years ago (Nov 4, 2019 11:06am UTC)

Loading

Pipeline #93457946 failed

Pipeline failed for 5f0eb8ea on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 47 commits

    added 47 commits

    • 9483040f...ecb915ef - 45 commits from branch master
    • ac4c1ec4 - Merge branch 'master' of gitlab.com:minds/front into fix/upload-cancel-2083
    • 2444cfdd - Added in missing clientService put

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • There are still issues here.

  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 1 commit

    added 1 commit

    • 870a33b9 - Call abort regardless to deal with timing issues

    Compare with previous version

  • Mark Harding approved this merge request

    approved this merge request

  • merged

  • Mark Harding mentioned in commit 5f0eb8ea

    mentioned in commit 5f0eb8ea

  • Please register or sign in to reply
    Loading