Skip to content
Snippets Groups Projects

[Sprint/NuancedNumbat](fix): Do not show post if deleted.

Closed Ben requested to merge fix/activity-deletion-detection-1732 into master

Closes #1732 (closed)

I believe this to be the correct way to take care of it, as the remaining line after deletion caused by border offers an indicator of where the post was. Can be taken care of if anybody disagree's - easy enough to add conditional css but I left it in because it felt better to me.

It appears that the _deleted event emitter is not implemented properly, but I don't feel deferring 'deletion' to the parent is the correct solution anyway.

Note in the HTML file, all I have done is wrapped it in an ng-container conditionally tied to whether the post is in a deleted or not. The large amount of changes come from adjusting the indentation.

Merge request reports

Checking pipeline status.

Closed by BenBen 5 years ago (Oct 14, 2019 8:25pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading