Skip to content
Snippets Groups Projects

[Sprint/ModestMonkey](fix): Return void if there is no selected or deselected image

Merged Ben requested to merge fix/blogs-image-select-1791 into master
All threads resolved!

Closes #1791 (closed)

The issue is in the image embed, on image click. This is bound as an onclick event and if its firing on an image, and if e.target doesn't exist, we should just be returning void.

To test please go make a blog, add an image, click it, deselect etc.

Edited by Ben

Merge request reports

Checking pipeline status.

Approved by

Merged by Mark HardingMark Harding 5 years ago (Sep 5, 2019 9:18pm UTC)

Merge details

  • Changes merged into master with 60a74dfa (commits were squashed).
  • Deleted the source branch.

Pipeline #80592826 passed with warnings

Pipeline passed with warnings for 60a74dfa on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 1 commit

    added 1 commit

    • e5238358 - Update embed-image.plugin.ts

    Compare with previous version

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Ben resolved all threads

    resolved all threads

  • Ben mentioned in issue #1813 (closed)

    mentioned in issue #1813 (closed)

  • Mark Harding
  • Mark Harding added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben added 1 commit

    added 1 commit

    • aa71ff28 - Fixed null images causing error

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Ben added 1 commit

    added 1 commit

    • 1aa5d2c7 - Update embed-image.plugin.ts

    Compare with previous version

  • Emiliano Balbuena approved this merge request

    approved this merge request

  • Brian Hatchet approved this merge request

    approved this merge request

  • merged

  • Mark Harding mentioned in commit 60a74dfa

    mentioned in commit 60a74dfa

  • Please register or sign in to reply
    Loading