Skip to content
Snippets Groups Projects

[Sprint/KiltedKoala](feat): Added in comment-tree e2e tests #1635

Merged Ben requested to merge feat/comment-tree-e2e-1635 into master

Closes #1635 (closed)

Took longer than initially anticipated, decided to make sure the voting works while I was in here.

Note indexes for the functions at ln:29 all equal 2 because that is the position we need for the top element on the comment tree, but the framework is there to grab 2nd, 3rd commments in a clean way.

GitLabs pipeline formatting is screwed up at the moment, and everything outputs on a new line. To make output readable, run

var style = document.createElement('style');
style.innerHTML = '.build-page .section-header ~ .section.line {margin-left: 0px !important; display: inline !important;}';

var ref = document.querySelector('script');
ref.parentNode.insertBefore(style, ref);

In browser console on the page.

Edited by Ben

Merge request reports

Checking pipeline status.

Approved by

Merged by Brian HatchetBrian Hatchet 5 years ago (Aug 16, 2019 5:17pm UTC)

Merge details

  • Changes merged into master with c55bb642 (commits were squashed).
  • Deleted the source branch.

Pipeline #76806906 waiting for manual action

Pipeline waiting for manual action for c55bb642 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading