[Sprint/KiltedKoala](chore): Adding in fdescribe / fit checks in git hooks #1608
Partially closes #1608 (closed)
Try commit an fdescribe or fit.
Merge request reports
Activity
One thing to note, these may not work unless "chmod +x .githooks/pre-commit" is ran. I've omitted that for now else we'll run into compat issues with Windows - Could use something like this if that is the case https://stackoverflow.com/a/8597411/7396007.
Just had to made it executable and it works in the happy path case. Aka, if there is no f* in the code, it won't let you add them. However, there's a problem in the script if you try to remove and existing one. It will detect the change and pick it up as a potential add even if it's a -fdescribe line
It also requires NPM to be installed, so we'll need to broadcast to all developers that they need to update their locals so it sticks.
-
Approved, but this one definitely requires @markeharding 's blessing
added 9 commits
-
b46a5087...6d942fb6 - 8 commits from branch
master - ce159635 - Merge branch 'master' into feat/fdesc-hook-1608
-
b46a5087...6d942fb6 - 8 commits from branch
mentioned in commit 2e95c013