Skip to content
Snippets Groups Projects

WIP: [Sprint/JollyJellyfish](feat) Plus tiers engine#578

Closed Ben requested to merge feat/plus-tiers-578 into master

Depends on engine#578 (closed) Closes mobile-native#1093 (moved)

Need to add tests before im happy.

Edited by Ben

Merge request reports

Checking pipeline status.

Requires 1 approval from Deployers.

Closed by BenBen 5 years ago (Nov 6, 2019 10:17pm UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Harding
  • Looking good. Beware of modal -> modal flow though, I think it will replace it and close the previous one down (so not going back).

    Also, please don't push up fit.. we should open a ticket to put something in the CI to warn us.

  • Ben added StatusRequires Changes + 1 deleted label

    added StatusRequires Changes + 1 deleted label

  • Crap! Sorry about that. Made a ticket for it here minds#694 (closed)

    I'll have a think about it. I had a google and found a few hooks we could maybe use / adapt

  • Ben added 1 commit

    added 1 commit

    • 56321036 - Updated to meet feedback (please squash)

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 commit

    added 1 commit

    • bc487db6 - Grabbed plus user from config

    Compare with previous version

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Awaiting feedback to continue and make responsive.

  • Somewhat of a discrepancy from my local and this here pipeline. The engine seems to be functioning correctly, because the new config endpoint served value for plus_guid is available on the site at Minds.blockchain.plus_guid. (can the sandbox using web dev tools).

    The front-end here, in contrast to my local does not working at all, as the modal doesn't pop-up.

    minds-plus-tiers

  • Ben unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ben marked as a Work In Progress

    marked as a Work In Progress

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading