Skip to content
Snippets Groups Projects

[Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366

Closed Ben requested to merge fix/default-preferred-state-1366 into master

Closes #1302 (closed)

Test that your selection for preferred is remembered in local storage.

  1. Set it to on
  2. Tab over to wallet or another page
  3. Refresh
  4. Visit discovery - it should have remembered the state was on.
  5. Turn it off, and repeat to confirm that is remembers the 'off' state
Edited by Ben

Merge request reports

Checking pipeline status.

Closed by BenBen 5 years ago (Nov 6, 2019 11:02pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ben added 1 commit

    added 1 commit

    • 04c502a3 - Emit event on load to set querystring properly

    Compare with previous version

  • Ben resolved all threads

    resolved all threads

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • Mark Harding added 1 deleted label

    added 1 deleted label

  • Ben added 217 commits

    added 217 commits

    • 04c502a3...d69d2bd0 - 216 commits from branch master
    • 92f471ca - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366

    Compare with previous version

  • Ben changed title from [Sprint/InterestingIguana] Preferred hashtag remembered in local storage #1366 (closed) to [Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366 (closed)

    changed title from [Sprint/InterestingIguana] Preferred hashtag remembered in local storage #1366 (closed) to [Sprint/InterestingIguana](feat): Preferred hashtag remembered in local storage #1366 (closed)

  • Ben changed the description

    changed the description

  • Ben added 1 commit

    added 1 commit

    Compare with previous version

  • Ben added StatusRequires Changes label and removed 1 deleted label

    added StatusRequires Changes label and removed 1 deleted label

  • Not working correctly.

    Steps to reproduce faulty behaviour:

    1. Turn off preferred in discovery. (This saves the cookie to the off state).
    2. Click over to another page (do not reload)
    3. Go back to discovery - preferred will be switched on when it should not be.
  • Ben added 1 commit

    added 1 commit

    • 306c6330 - Removed line causing undesired preferred tag emission.

    Compare with previous version

  • Ben added 1 deleted label and removed StatusRequires Changes label

    added 1 deleted label and removed StatusRequires Changes label

  • This was caused by src/app/modules/newsfeed/newsfeed.component.html trying to set the value of preferred via the input.

  • Ben added 112 commits

    added 112 commits

    • 306c6330...534f449e - 111 commits from branch master
    • 4e6864e1 - Merge branch 'master' of gitlab.com:minds/front into fix/default-preferred-state-1366

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading