Skip to content
Snippets Groups Projects

[Sprint/InterestingIguana](bug) Progress bar prematurely finishes on upload end, not on request end. #1500

Merged Ben requested to merge fix/progress-indicator-upload-1500 into master

The issue with comments at the comment is that the XHR progress event returns 100% when the image is uploaded - this is not the end of the network request though, as there is additional server side processing done. The rationale behind doing it this way, is that the progress bar, to the average user, simply means "How long until I can hit post" - they do not care about whether the image is uploaded or not.

In addition I added if (e.lengthComputable) { which should catch some future errors.

Merge request reports

Checking pipeline status.

Approved by

Merged by Mark HardingMark Harding 5 years ago (Jul 8, 2019 3:11pm UTC)

Merge details

  • Changes merged into master with d7f9cc7d (commits were squashed).
  • Deleted the source branch.

Pipeline #69922354 passed

Pipeline passed for d7f9cc7d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading