Fix legacy usd option appearing

Summary

Closes #2593 (closed)

Legacy boost prompt that allows payment in USD still appears sometimes.

Rather than refactoring down the class right now I've opted to stop it showing. We should schedule a refactor / remake of this in the future.

Steps to test

1. Go to someone else's channel and click to Wire them on a post.
2. Toggle over to send them USD.
3. Exit wire prompt without making payment.
4. Go back to your channel and click boost on your post.
5. There should be nothing like the below image in the modal window.

Estimated Regression Scope

Maybe it could show at an inappropriate time, or in some circumstance the cookie works. Maybe this creator is re-used somewhere where USD is valid that I am unaware of/

added 1 deleted label

added 1 commit

• cae333a7 - Fixed legacy usd modal showing for boosts

Compare with previous version

changed the description

Works OK!

approved this merge request

Got the old screen by going through the steps to reproduce

added StatusRequires Changes label and removed 1 deleted label

added StatusReady to Merge label and removed StatusRequires Changes label

approved this merge request

This is what I get.

It looks like the screen I'm not supposed to see except for the priority stuff at the bottom.

Jack says it's good.

approved this merge request

merged

mentioned in commit f335566b