Logged out update markers calls #2577
Summary
Closes #2577 (closed)
In some weird set of circumstances, it appears that users can call the api/v1/groups/member endpoint while not logged in.
Steps to test
Neither I nor @brianhatchet have been able to replicate this locally.
Estimated Regression Scope
Not really much I can think of. It's just adding a logged in check to a function so that an endpoint with no purpose for a logged-out user, isn't called when logged out.
Merge request reports
Activity
added StatusRequires Changes label and removed 1 deleted label
@benhayward.ben looks like some other stuff got put in here. Can you cleanup before we merge?
assigned to @benhayward.ben
added 42 commits
-
79aa76a4...d3223fbc - 41 commits from branch
master
- f77266ab - Merge branch 'master' of gitlab.com:minds/front into fix/logged-out-update-markers-2577
-
79aa76a4...d3223fbc - 41 commits from branch
added StatusReview label and removed StatusRequires Changes label
added 3 commits
-
f77266ab...18d19ab7 - 2 commits from branch
master
- 7c0a8f2c - Merge remote-tracking branch 'origin/master' into fix/logged-out-update-markers-2577
-
f77266ab...18d19ab7 - 2 commits from branch
added 38 commits
-
7c0a8f2c...e6a09425 - 36 commits from branch
master
- bcdfde6c - Merge branch 'master' of gitlab.com:minds/front into fix/logged-out-update-markers-2577
- d62a9fdd - Merge branch 'fix/logged-out-update-markers-2577' of gitlab.com:minds/front...
-
7c0a8f2c...e6a09425 - 36 commits from branch
Not sure how to test this. Code looks good, however we need to ensure
load()
gets called again when the user logs in.cc/ @benhayward.ben
Edited by Emiliano Balbuenaadded 1 deleted label and removed StatusReview label
mentioned in commit e177698d