Skip to content
Snippets Groups Projects

Fix/url hashtag count #2361

Merged Fix/url hashtag count #2361
fix/url-hashtag-count into master
Merged Ben requested to merge fix/url-hashtag-count into master

Summary

Closes #2361 (closed)

** note this MR includes the new installer changes, wait for that before merge **

Added in a check for whether the matching tag is located in a URL.

Steps to Test

This one is a bit more "get in there and try your best to break it" in terms of testing, but that said, to get a foot in the door:

  1. Go on the site, make a post with 5 hashtags; try to trip the Regex up and make some invalid tags to see how it responds to the max count.
  2. Try a URL with a hashtag in.
  3. Check the hashtags links go through to the correct place.
  4. Try to use the hashtag selector to bypass the limit
  5. Ensure when you add a tag it shows up in the selector

Estimated Regression Scope

This change could affect the poster in different environments, it could perhaps trigger something that should still not be a hashtag as a hashtag

Merge request reports

Checking pipeline status.

Approved by
Xander Miller Brian Hatchet

Merged by Xander MillerXander Miller 5 years ago (Feb 20, 2020 3:43pm UTC)

Merge details

  • Changes merged into master with eae61c19 (commits were squashed).
  • Deleted the source branch.

  • Mentions issue #2361 (closed)

Pipeline #119672368 waiting for manual action

Stage: test
Stage: build
Stage: prepare
Stage: review
Stage: deploy:staging
Stage: qa
Stage: deploy:canary
Stage: deploy:production

Pipeline waiting for manual action for eae61c19 on master

4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply