Skip to content
Snippets Groups Projects

WIP: Fix Campaigns get marked as complete on first view

Merged Guy Thouret requested to merge fix-campaign-complete-1252 into epic/boost-campaign

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Guy Thouret added TypeBug + 1 deleted label

    added TypeBug + 1 deleted label

  • Author Contributor

    Currently throwing a 500 for:

    2019/12/20 16:57:04 [error] 8#8: *1372 FastCGI sent in stderr: "PHP message: Exception #1576861024: Exception: Expected a numeric value in /var/www/Minds/engine/Core/Util/BigNumber.php:385
    Stack trace:
    #0 /var/www/Minds/engine/Core/Util/BigNumber.php(30): Minds\Core\Util\BigNumber->normalize('')
    #1 /var/www/Minds/engine/Core/Util/BigNumber.php(331): Minds\Core\Util\BigNumber->__construct(NULL, 18)
    #2 /var/www/Minds/engine/Core/Boost/Network/ElasticRepository.php(280): Minds\Core\Util\BigNumber::fromPlain(NULL, 18)
    #3 /var/www/Minds/engine/Core/Boost/Network/ElasticRepository.php(344): Minds\Core\Boost\Network\ElasticRepository->add(Object(Minds\Core\Boost\Network\Boost))
    #4 /var/www/Minds/engine/Core/Boost/Network/Manager.php(171): Minds\Core\Boost\Network\ElasticRepository->update(Object(Minds\Core\Boost\Network\Boost), Array)
    #5 /var/www/Minds/engine/Core/Boost/Network/Manager.php(166): Minds\Core\Boost\Network\Manager->resync(Object(Minds\Core\Boost\Network\Boost), Array)
    #6 /var/www/Minds/engine/Core/Boost/Network/Manager.php(210): Minds\Core\Boost\Network\Manager" while reading response header from upstream, client: 172.18.0.1, server: _, request: "POST /api/v2/analytics/views/boost/1054801464335011857 HTTP/1.1", upstream: "fastcgi://172.18.0.6:9000", host: "localhost:8080", referrer: "http://localhost:8080/newsfeed/subscriptions"
  • Author Contributor

    To make a campaign compatible with legacy code during deployment we should just set the unused 'impressions' field to a really large integer or this 'bug' will be triggered if a campaign post is picked up before the new code has fully rolled out. Perhaps by setting a default in the campaign model that we never override when constructing a new model from repository.

  • Guy Thouret added 5 commits

    added 5 commits

    • 77fa1e27 - (fix) Add guid query to Boost ElasticRepository - Fixes #1249 (closed)
    • 4f8b37e4 - (feat) Admins can approve posts in a Boost Campaign - #1170 (closed)
    • c9d6b183 - Merge branch 'fix-campaign-view-1249' into 'epic/boost-campaign'
    • d55c3324 - Merge branch 'feat/1170-admin-approve-campaign' into 'epic/boost-campaign'
    • c9b4b04f - (fix) Correct handling of Boost campaign views and expiry - #1252 (closed)

    Compare with previous version

  • Guy Thouret changed target branch from master to epic/boost-campaign

    changed target branch from master to epic/boost-campaign

  • Author Contributor

    Mr was targeting the wrong branch

  • merged

Please register or sign in to reply
Loading