Skip to content
Snippets Groups Projects

Extract record view details from analytics/views api call

Merged Guy Thouret requested to merge extract-view-api-1077 into epic/boost-campaign

The details of recording a view are hidden away inside the api call.

These details should be in a class (or set of classes) within the code base and be subject to testing with the API left to do it's job of parameter parsing and error handling.

The motivation for this refactor is the ongoing boost improvements. A critical piece of boost functionality that marks a boost as expired has been hidden away inside this seemingly unrelated API call.

Closes #1077 (closed)

Testing Steps:

  • Scroll down newsfeed
  • Make a note of the view counters
  • Wait an indeterminate amount of time (Counters are stored on the entity within ES?)
  • Refresh page
  • The view counters should have increased by 1
Edited by Guy Thouret

Merge request reports

Checking pipeline status.

Merged by Guy ThouretGuy Thouret 5 years ago (Dec 20, 2019 10:17am UTC)

Loading

Pipeline #104587602 failed

Pipeline failed for 83f925a5 on epic/boost-campaign

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading