Skip to content

[Sprint/QuietQuail](fix): GIF resize and cropping.

Ben requested to merge fix/gif-resize into master

Closes #907 (closed)

Summary

On production, if you upload a gif as your avatar, 2 things:

  1. The resize is broken. If you take the image URL and change between large and small, there is no difference.
  2. The GIF will not be cropped, so if it's wide or long, it will be malformed in older areas like "create new blog".
  3. The GIF will likely appear as a quite a glitchy still-frame. (it should be a still-frame but not glitchy)
Prod

image

Testing

Firstly, I recommend you grab a testing gif. I used the following.

longishgif

Try setting that as your avatar on production to see the issue, also head over to 'Create Blog' which is an older page that does not have front-end validation to stop the image from covering an extra-wide space.

For testing, try it on a sandbox, check all the places your avatar will be. Post it a few places and make sure the gif isn't messed with and image files can all still be uploaded fine around the site. I could not find any outliers where this did not cover it.

Sandbox

image

Merge request reports