(fix): don't do anything if the entity isn't an image or video (!365) · Merge requests · Minds / Minds Backend - Engine · GitLab

Snippets Groups Projects

Merged Marcelo Rivera requested to merge fix/sentry-issue-925 into master 5 years ago

1 unresolved thread

closes #925 (closed)

Activity

Marcelo Rivera changed milestone to %Misc. Q4 2019 5 years ago

changed milestone to %Misc. Q4 2019
Marcelo Rivera added 1 deleted label 5 years ago

added 1 deleted label
Mark Harding added StatusRequires Changes label 5 years ago

added StatusRequires Changes label
Mark Harding @markharding · 5 years ago

Owner

Linting issues @eiennohi
Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Controllers/api/v1/media.php

36	36	return Factory::response(['status' => 'error']);
37	37	}
38	38
	39	if (!in_array(['object:video', 'object:image'], $entity->type)) {
Mark Harding @markharding · 5 years ago Owner type will always be object? Marcelo Rivera changed this line in version 2 of the diff 5 years ago changed this line in version 2 of the diff Marcelo Rivera @eiennohi · 5 years ago Author Contributor Just fixed this line. I think the issue came from someone going into /media/:guid, with an activity guid instead of an image or video. That's why I'm doing the check Please register or sign in to reply

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

e3bac422 - (fix): don't do anything if the entity isn't an image or video

Compare with previous version

Marcelo Rivera @eiennohi · 5 years ago

Author Contributor

@markeharding, I just updated

Mark Harding approved this merge request 5 years ago

approved this merge request

Mark Harding mentioned in commit 5 years ago

mentioned in commit bfac17ad

Mark Harding merged 5 years ago

merged

Please register or sign in to reply