Skip to content

Modernize Router (&75)

Emiliano Balbuena requested to merge epic/modern-router into master

Testing

  • Basically the whole site should be functional. Don't forget to test uploads, avatar changes, deleting stuff, etc. Network activity on Dev Tools should behave as usual. Don't solely focus on AJAX (XHR) requests, /fs and the initial HTML document go thru it.

How do I know if I'm over the new router?

Check Response Headers in your Dev Tools. All the non-static requests should have a X-Route-Resolver: <value> header set. Also, window.Minds.features["psr7-router"] should be true.

Possible values are:

  • route-resolver: New Module-based Router. No endpoints are using this, yet.
  • pre-psr7: JSON API requests handled by old Router.
  • pre-psr7-static: HTML requests handled by old Router. Right now, the initial HTML request is the only one.

Issues

Edited by Emiliano Balbuena

Merge request reports

Loading