[Sprint/NuancedNumbat](fix): Ban email now returning string of ban reason rather than index.

Closes #867 (closed)

Depends on helm-charts!41 (merged)

Summary

Change integers returned into their human readable banned reason.

Steps to test

Emails ARE working on sandboxes now, but the Email runner still isn't, this means directly dispatched emails send instantly (like the 3 strikes email), queued ones do not (like the one we're changing).

tl;dr Will require kubectl access

1. kubectl exec into the container.
2. cd engine.
3. php ./cli.php QueueRunner run --runner=Email.
4. Now log in as sandbox admin and ban a user for spam.
5. Reason should come through in the email.

Regression Scope

This is mostly additions so I wouldn't expect there's much room for anything to go wrong outside of the new additions being faulty in some way. I suppose as a ground zero, worst case scenario; ban email maybe doesn't send because of an uncaught error, but this isn't likely or the case when testing.

added StatusRequires Changes + 1 deleted label

added 1 deleted label and removed StatusRequires Changes label

added StatusRequires Changes label and removed 1 deleted label

added 1 commit

• c96f482e - Changed location of call and put ban reasons in settings

Compare with previous version

added 1 commit

• 117f089c - Accidental commit

Compare with previous version

resolved all threads

added 1 commit

• 5559e8de - Linting

Compare with previous version

added 1 deleted label and removed StatusRequires Changes label

mentioned in issue #868 (closed)

added StatusRequires Changes label and removed 1 deleted label

marked as a Work In Progress

added 1 deleted label and removed StatusRequires Changes label

closed

reopened

added 1 commit

• c4809d98 - Added $this

Compare with previous version

resolved all threads

added StatusRequires Changes label and removed 1 deleted label