(fix) Handle ImagickException in blog api where an invalid image file is passed - #770

This error could be triggered by uploading a 0 byte file as a banner image.

Created by e.g. touch testimage.jpg.

This is now handled and api will return a correct error response.

added Priority1 - High ProductBlogs + 1 deleted label

Received the following error when changing banner.

[05-Sep-2019 19:29:33] WARNING: [pool www] child 596 said into stderr: "NOTICE: PHP message: Exception #1567711773: ImagickException: no decode delegate for this image format `' @ error/constitute.c/ReadImage/504 in /var/www/Minds/engine/Core/Media/Imagick/Manager.php:59"

Also, does this exception also not trigger on image uploads in comments and newsfeed?

added StatusRequires Changes label and removed 1 deleted label

Should be seeing this...

According to the Sentry logs it's always thrown from the same place for the same request - /api/v1/blogs/new so this will resolve that issue.

added 1 deleted label and removed StatusRequires Changes label

Editing an existing banner to an invalid file is producing the same correct 'Invalid image file' response.

This is in dev env because review site has been taken down.

approved this merge request

mentioned in commit 61f0bd82

merged