[Sprint/GiddyGiraffe] (fix): don't show suggestions if near subscriptions ratelimit threshold (!192) · Merge requests · Minds / Minds Backend - Engine · GitLab

Snippets Groups Projects

Merged Marcelo Rivera requested to merge eiennohi/engine:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold into master 5 years ago

All threads resolved!

closes #267 (closed)

Approved by

Activity

Mark Harding @markharding 5 years ago

Owner

Can this be moved to Manager with spec tests for safety?
Marcelo Rivera added 2 commits 5 years ago
added 2 commits

99204fa7 - (fix): don't show suggestions if near subscriptions ratelimit threshold

30c527c7 - (feat): spec tests

Compare with previous version
Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Ben
Last reply by Marcelo Rivera 5 years ago

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

a630a65e - (fix): delegates should be stateless

Compare with previous version

Mark Harding @markharding 5 years ago

Owner

@eiennohi don't forget about these.. also failing spec tests

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

6c92280e - (fix): delegates should be stateless

Compare with previous version

Brian Hatchet approved this merge request 5 years ago

approved this merge request

Emiliano Balbuena @edgebal started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Ben resolved all discussions 5 years ago

resolved all discussions

Mark Harding added 1 deleted label 5 years ago

added 1 deleted label

Mark Harding approved this merge request 5 years ago

approved this merge request

Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Mark Harding @markharding started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Mark Harding added label and removed 1 deleted label 5 years ago

added StatusRequires Changes label and removed 1 deleted label

Mark Harding @markharding started a thread on the diff 5 years ago

Resolved 5 years ago by Marcelo Rivera

Mark Harding unapproved this merge request 5 years ago

unapproved this merge request

Marcelo Rivera resolved all threads 5 years ago

resolved all threads

Marcelo Rivera added 143 commits 5 years ago

added 143 commits

6c92280e...5e6901e0 - 138 commits from branch minds:master
d85520a8 - Merge remote-tracking branch 'upstream/master' into...
f5b62627 - (fix): use correct mapping
f1fe5785 - (fix): should cache specifically when subscribing
77064e0d - (fix): spec tests
7ff36c15 - (fix): don't use null colaescing operator

Compare with previous version

Toggle commit list

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

a9e0452d - (fix): cleanup

Compare with previous version

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

4a915434 - (fix): several fixes and cleanup

Compare with previous version

Marcelo Rivera added 1 commit 5 years ago

added 1 commit

ec4f4b04 - (fix): several fixes and cleanup

Compare with previous version

Mark Harding added 1 deleted label 5 years ago

added 1 deleted label

Mark Harding approved this merge request 5 years ago

approved this merge request

Mark Harding merged 5 years ago

merged

Mark Harding mentioned in commit 5 years ago

mentioned in commit 11bb14cd

Please register or sign in to reply