1. 22 Oct, 2018 1 commit
    • Steve Azzopardi's avatar
      Add missing error checks · e4bfe44f
      Steve Azzopardi authored
      Files are being written to without checking the error message, which
      might lead to false positives or hard to debug tests.
      e4bfe44f
  2. 17 Oct, 2018 1 commit
    • Tomasz Maczukin's avatar
      Merge branch... · c847d0ac
      Tomasz Maczukin authored
      Merge branch '3639-follow-up-from-resolve-add-docker-support-for-interactive-web-terminal' into 'master'
      
      Resolve "Follow-up from Add docker support for interactive web terminal"
      
      Closes #3639
      
      See merge request gitlab-org/gitlab-runner!1049
      c847d0ac
  3. 16 Oct, 2018 1 commit
  4. 08 Oct, 2018 12 commits
  5. 05 Oct, 2018 7 commits
    • Steve Azzopardi's avatar
      Add test for docker exit · e18dc3d1
      Steve Azzopardi authored
      Test when the container exists and check that the session is cleaned up
      correctly.
      e18dc3d1
    • Steve Azzopardi's avatar
      Clean up tests · 959ebacb
      Steve Azzopardi authored
      Fix `Fail in goroutine after TestInteractiveTerminal has completed`
      because of the assertion was in the goroutine.
      
      Remove `TestInteractiveWebTerminalAttachStrategy` since it is not really
      testing anything new.
      959ebacb
    • Steve Azzopardi's avatar
      Add tests for docker executor terminal · 3484a1de
      Steve Azzopardi authored
      3484a1de
    • Kamil Trzciński's avatar
      Actively watch for the exec container · a951a76b
      Kamil Trzciński authored
      - Kill the terminal connection if container exits
      - Fix deadlock in build container method flow
      - Fix closing terminal connection, resolving the problem
        of terminal still being connected even though
        it is disconnected
      a951a76b
    • Steve Azzopardi's avatar
      Kill session only on UserScript stage · dd7dc6df
      Steve Azzopardi authored
      When the build container is done the session server needs to be
      notified, so waitForTerminal is not triggered then the job is finished,
      since the user can no longer user the terminal, because the container is
      dead.
      dd7dc6df
    • Steve Azzopardi's avatar
      Add web terminal for docker executor · c45fc343
      Steve Azzopardi authored
      Use reflect.DeepEqual for session.closeTerminalConn since the struct
      might have slices which are not comparable.
      
      Make the docker executor implement the `session.Conn` &
      `session.InteractiveTerminal` interface to support interactive web
      terminals.
      
      Update `gitlab-terminal` package to version to support docker stream.
      c45fc343
    • Steve Azzopardi's avatar
      Fix test assertion · c11d6abc
      Steve Azzopardi authored
      The assertion was the other way round.
      c11d6abc
  6. 01 Oct, 2018 2 commits
  7. 06 Sep, 2018 1 commit
  8. 04 Sep, 2018 2 commits
  9. 14 Aug, 2018 1 commit
  10. 07 Aug, 2018 2 commits
  11. 01 Aug, 2018 1 commit
  12. 30 Jul, 2018 2 commits
  13. 27 Jun, 2018 1 commit
  14. 20 Jun, 2018 1 commit
  15. 18 Jun, 2018 2 commits
  16. 15 Jun, 2018 3 commits