Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • oga oga
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Yorick Peterse
  • ogaoga
  • Merge requests
  • !190

Suppress keyword arguments warning

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged KitaitiMakoto requested to merge KitaitiMakoto/oga:suppress-keyword-arguments-warning into master Jan 10, 2020
  • Overview 2
  • Commits 2
  • Pipelines 1
  • Changes 2

Hi,

Since Ruby 2.7, it warns **kwargs in method signatures and Oga is warned:

/home/kitaitimakoto/src/gitlab.com/yorickpeterse/oga/lib/oga/xml/querying.rb:67: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call /home/kitaitimakoto/src/gitlab.com/yorickpeterse/oga/lib/oga/xml/querying.rb:43: warning: The called method `xpath' is defined here

/home/kitaitimakoto/src/gitlab.com/yorickpeterse/oga/spec/oga/xml/querying_spec.rb:22: warning: Passing the keyword argument as the last hash parameter is deprecated /home/kitaitimakoto/src/gitlab.com/yorickpeterse/oga/lib/oga/xml/querying.rb:43: warning: The called method `xpath' is defined here

This patches suppress the warnings.

Thanks.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: suppress-keyword-arguments-warning