Skip to content

rook: Fix host network value templating

Steve Starke requested to merge sstrk/rook-fix-host-network into devel

Version Control Information

Source branch: sstrk/rook-fix-host-network
Target branch: devel

Commits:

* rook: Fix host network value templating

The "provider"-key has to be on the same hierarchy level as e.g.
"connections", directly under the "network"-key [1]. This was misplaced
in 04d16facac9bf39aa1a1f15b12cfeb355dccb324.

Unfortunately, helm does not complain about false values.

[1] https://github.com/rook/rook/blob/78b29ff4db39241838a3dfeb94364a6b3f16333a/deploy/charts/rook-ceph-cluster/values.yaml

Description

Feel free to add further information about your MR in this section

Closes: #


Merge Prerequisites

  • MR title (and description) are descriptive
  • Code is readable and syntactically correct
  • Code is understandable
  • Documentation has been updated, if necessary
  • Commit messages look good
  • Release note file added in latest commit

As a developer: please do not tick these boxes yourself. As a reviewer: please get yourself a hot cold beverage.

Merge request reports

Loading