Skip to content

rook_v2: Allow to unset CPU limits

Steve Starke requested to merge sstrk/rook-unset-cpu-limits into devel

Version Control Information

Source branch: sstrk/rook-unset-cpu-limits
Target branch: devel

Commits:

* rook_v2: Allow to unset CPU limits

Previously, it was not possible to unset CPU limits for these as even if
not defined, the helm chart default values would have been used. So we
must explicitly overwrite the value with "null".

Not done for rook_v1 as its deprecated and will be dropped in !1042.

Closes: #627

Description

Feel free to add further information about your MR in this section

Closes: #627 (closed)


Merge Prerequisites

  • MR title (and description) are descriptive
  • Code is readable and syntactically correct
  • Code is understandable
  • Documentation has been updated, if necessary
  • Commit messages look good
  • Release note file added in latest commit

As a developer: please do not tick these boxes yourself. As a reviewer: please get yourself a hot cold beverage.

Edited by Steve Starke

Merge request reports

Loading