Assigning a suite that is unavailable to be assigned causes an error
Steps to replicate (race condition):
- Draw in suite selection mode with multiple suites of one size
- Visit suite assignment page for a group of that size
- IN A SEPARATE WINDOW, create a special group of that size and assign one of the suites from the draw to it
- In the suite assignment window, attempt to assign the newly unavailable suite to the group
Expected: Some kind of reasonable error flash message
Actual:
2019-03-20T16:16:26.853584+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] Completed 500 Internal Server Error in 272ms (ActiveRecord: 128.7ms)
2019-03-20T16:16:26.863300+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013]
2019-03-20T16:16:26.864749+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] NoMethodError (undefined method `join' for #<ActiveModel::Errors:0x00007fb48c885f98>):
2019-03-20T16:16:26.869713+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013]
2019-03-20T16:16:26.869805+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:93:in `block in errors_from_results'
2019-03-20T16:16:26.869808+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:91:in `each'
2019-03-20T16:16:26.869810+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:91:in `errors_from_results'
2019-03-20T16:16:26.869811+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:66:in `process_all_suite_selections'
2019-03-20T16:16:26.869813+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:38:in `block in assign'
2019-03-20T16:16:26.869815+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/forms/suite_assignment_form.rb:38:in `assign'
2019-03-20T16:16:26.869816+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] app/controllers/suite_assignments_controller.rb:15:in `create'
2019-03-20T16:16:26.869818+00:00 app[web.1]: [8c927366-5995-4c62-8edd-dfaa8a84c013] lib/rescued_apartment_middleware.rb:7:in `call'
Edited by Oren Kanner