Skip to content
  • Elijah Newren's avatar
    treewide: ensure one of the appropriate headers is sourced first · 8bff5ca0
    Elijah Newren authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    We had several C files ignoring the rule to include one of the
    appropriate headers first; fix that.
    
    While at it, the rule in Documentation/CodingGuidelines about which
    header to include has also fallen out of sync, so update the wording to
    mention other allowed headers.
    
    Unfortunately, C files in reftable/ don't actually follow the previous
    or updated rule.  If you follow the #include chain in its C files,
    reftable/system.h _tends_ to be first (i.e. record.c first includes
    record.h, which first includes basics.h, which first includees
    system.h), but not always (e.g. publicbasics.c includes another header
    first that does not include system.h).  However, I'm going to punt on
    making actual changes to the C files in reftable/ since I do not want to
    risk bringing it out-of-sync with any version being used externally.
    
    Signed-off-by: default avatarElijah Newren <newren@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    8bff5ca0