Skip to content
  • Jeff King's avatar
    argv-array: rename to strvec · 873cd28a
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    The name "argv-array" isn't very good, because it describes what the
    data type can be used for (program argument arrays), not what it
    actually is (a dynamically-growing string array that maintains a
    NULL-terminator invariant). This leads to people being hesitant to use
    it for other cases where it would actually be a good fit. The existing
    name is also clunky to use. It's overly long, and the name often leads
    to saying things like "argv.argv" (i.e., the field names overlap with
    variable names, since they're describing the use, not the type). Let's
    give it a more neutral name.
    
    I settled on "strvec" because "vector" is the name for a dynamic array
    type in many programming languages. "strarray" would work, too, but it's
    longer and a bit more awkward to say (and don't we all say these things
    in our mind as we type them?).
    
    A more extreme direction would be a generic data structure which stores
    a NULL-terminated of _any_ type. That would be easy to do with void
    pointers, but we'd l...
    873cd28a