• Ronnie Sahlberg's avatar
    checkout.c: use ref_exists instead of file_exist · 482b8f32
    Ronnie Sahlberg authored
    Change checkout.c to check if a ref exists instead of checking if a loose ref
    file exists when deciding if to delete an orphaned log file. Otherwise, if a
    ref only exists as a packed ref without a corresponding loose ref for the
    currently checked out branch, we risk that the reflog will be deleted when we
    switch to a different branch.
    
    Update the reflog tests to check for this bug.
    
    The following reproduces the bug:
    $ git init-db
    $ git config core.logallrefupdates true
    $ git commit -m Initial --allow-empty
        [master (root-commit) bb11abe] Initial
    $ git reflog master
        [8561dcb master@{0}: commit (initial): Initial]
    $ find .git/{refs,logs} -type f | grep master
        [.git/refs/heads/master]
        [.git/logs/refs/heads/master]
    $ git branch foo
    $ git pack-refs --all
    $ find .git/{refs,logs} -type f | grep master
        [.git/logs/refs/heads/master]
    $ git checkout foo
    $ find .git/{refs,logs} -type f | grep master
        ... reflog file is missing ...
    $ git reflog master
        ... nothing ...
    Signed-off-by: default avatarRonnie Sahlberg <sahlberg@google.com>
    Acked-by: default avatarMichael Haggerty <mhagger@alum.mit.edu>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    482b8f32
t1410-reflog.sh 5.01 KB