Commit efc7df45 authored by Duy Nguyen's avatar Duy Nguyen Committed by Jeff King

Move print_commit_list to libgit.a

This is used by bisect.c, part of libgit.a while it stays in
builtin/rev-list.c. Move it to commit.c so that we won't get undefined
reference if a program that uses libgit.a happens to pull it in.
Signed-off-by: Duy Nguyen's avatarNguyễn Thái Ngọc Duy <[email protected]>
Signed-off-by: default avatarJeff King <[email protected]>
parent c43cb386
...@@ -11,10 +11,6 @@ extern struct commit_list *filter_skipped(struct commit_list *list, ...@@ -11,10 +11,6 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
int *count, int *count,
int *skipped_first); int *skipped_first);
extern void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last);
#define BISECT_SHOW_ALL (1<<0) #define BISECT_SHOW_ALL (1<<0)
#define REV_LIST_QUIET (1<<1) #define REV_LIST_QUIET (1<<1)
......
...@@ -201,16 +201,6 @@ static void show_edge(struct commit *commit) ...@@ -201,16 +201,6 @@ static void show_edge(struct commit *commit)
printf("-%s\n", sha1_to_hex(commit->object.sha1)); printf("-%s\n", sha1_to_hex(commit->object.sha1));
} }
void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last)
{
for ( ; list; list = list->next) {
const char *format = list->next ? format_cur : format_last;
printf(format, sha1_to_hex(list->item->object.sha1));
}
}
static void print_var_str(const char *var, const char *val) static void print_var_str(const char *var, const char *val)
{ {
printf("%s='%s'\n", var, val); printf("%s='%s'\n", var, val);
......
...@@ -1347,3 +1347,13 @@ struct commit_list **commit_list_append(struct commit *commit, ...@@ -1347,3 +1347,13 @@ struct commit_list **commit_list_append(struct commit *commit,
new->next = NULL; new->next = NULL;
return &new->next; return &new->next;
} }
void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last)
{
for ( ; list; list = list->next) {
const char *format = list->next ? format_cur : format_last;
printf(format, sha1_to_hex(list->item->object.sha1));
}
}
...@@ -222,4 +222,8 @@ struct commit *get_merge_parent(const char *name); ...@@ -222,4 +222,8 @@ struct commit *get_merge_parent(const char *name);
extern int parse_signed_commit(const unsigned char *sha1, extern int parse_signed_commit(const unsigned char *sha1,
struct strbuf *message, struct strbuf *signature); struct strbuf *message, struct strbuf *signature);
extern void print_commit_list(struct commit_list *list,
const char *format_cur,
const char *format_last);
#endif /* COMMIT_H */ #endif /* COMMIT_H */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment