Commit ce77aa48 authored by Jeff King's avatar Jeff King Committed by Junio C Hamano

credential: use git_prompt instead of git_getpass

We use git_getpass to retrieve the username and password
from the terminal. However, git_getpass will not echo the
username as the user types. We can fix this by using the
more generic git_prompt, which underlies git_getpass but
lets us specify an "echo" option.
Signed-off-by: default avatarJeff King <[email protected]>
Signed-off-by: default avatarJunio C Hamano <[email protected]>
parent a5090259
......@@ -109,7 +109,8 @@ static void credential_describe(struct credential *c, struct strbuf *out)
strbuf_addf(out, "/%s", c->path);
static char *credential_ask_one(const char *what, struct credential *c)
static char *credential_ask_one(const char *what, struct credential *c,
int flags)
struct strbuf desc = STRBUF_INIT;
struct strbuf prompt = STRBUF_INIT;
......@@ -121,11 +122,7 @@ static char *credential_ask_one(const char *what, struct credential *c)
strbuf_addf(&prompt, "%s: ", what);
/* FIXME: for usernames, we should do something less magical that
* actually echoes the characters. However, we need to read from
* /dev/tty and not stdio, which is not portable (but getpass will do
* it for us). http.c uses the same workaround. */
r = git_getpass(prompt.buf);
r = git_prompt(prompt.buf, flags);
......@@ -135,9 +132,11 @@ static char *credential_ask_one(const char *what, struct credential *c)
static void credential_getpass(struct credential *c)
if (!c->username)
c->username = credential_ask_one("Username", c);
c->username = credential_ask_one("Username", c,
if (!c->password)
c->password = credential_ask_one("Password", c);
c->password = credential_ask_one("Password", c,
int credential_read(struct credential *c, FILE *fp)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment