Commit a9bf09e1 authored by Jon Seymour's avatar Jon Seymour Committed by Junio C Hamano

detached-stash: simplify git stash show

This commit refactors git stash show to make use of the assert_stash_like function.

git show now dies if the presented argument is non-stash-like.

Previous behaviour was to tolerate commits that were not even stash-like.

Previously, git stash show would accept stash-like arguments, but
only if there was a stash on the stack.

Now, git stash accepts stash-like arguments always and only fails
if no stash-like argument is specified and there is no stash stack.
Signed-off-by: Jon Seymour's avatarJon Seymour <[email protected]>
Signed-off-by: default avatarJunio C Hamano <[email protected]>
parent fb433dc9
......@@ -210,19 +210,9 @@ list_stash () {
show_stash () {
have_stash || die 'No stash found'
flags=$(git rev-parse --no-revs --flags "[email protected]")
if test -z "$flags"
w_commit=$(git rev-parse --quiet --verify --default $ref_stash "[email protected]") &&
b_commit=$(git rev-parse --quiet --verify "$w_commit^") ||
die "'$*' is not a stash"
assert_stash_like "[email protected]"
git diff $flags $b_commit $w_commit
git diff ${FLAGS:---stat} $b_commit $w_commit
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment