Skip to content
  • Junio C Hamano's avatar
    fetch: work around "transport-take-over" hack · b26ed430
    Junio C Hamano authored
    
    
    A Git-aware "connect" transport allows the "transport_take_over" to
    redirect generic transport requests like fetch(), push_refs() and
    get_refs_list() to the native Git transport handling methods.  The
    take-over process replaces transport->data with a fake data that
    these method implementations understand.
    
    While this hack works OK for a single request, it breaks when the
    transport needs to make more than one requests.  transport->data
    that used to hold necessary information for the specific helper to
    work correctly is destroyed during the take-over process.
    
    One codepath that this matters is "git fetch" in auto-follow mode;
    when it does not get all the tags that ought to point at the history
    it got (which can be determined by looking at the peeled tags in the
    initial advertisement) from the primary transfer, it internally
    makes a second request to complete the fetch.  Because "take-over"
    hack has already destroyed the data necessary to talk to the
    transport helper by the time this happens, the second request cannot
    make a request to the helper to make another connection to fetch
    these additional tags.
    
    Mark such a transport as "cannot_reuse", and use a separate
    transport to perform the backfill fetch in order to work around
    this breakage.
    
    Note that this problem does not manifest itself when running t5802,
    because our upload-pack gives you all the necessary auto-followed
    tags during the primary transfer.  You would need to step through
    "git fetch" in a debugger, stop immediately after the primary
    transfer finishes and writes these auto-followed tags, remove the
    tag references and repack/prune the repository to convince the
    "find-non-local-tags" procedure that the primary transfer failed to
    give us all the necessary tags, and then let it continue, in order
    to trigger the bug in the secondary transfer this patch fixes.
    
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    b26ed430