JOSS Review
Hello William,
I am the second reviewer of your application to JOSS. First of all, great work! Second, I will open this general issue with all the issues I find, so it is easier to keep track of things. I will update this one as I add the other ones.
-
Instalation Example Error -
Missing Modules/Libraries in MyBinder -
Missing Documentation Link in the README -
Test Coverage Badge shows Unknown -
Python Versions/Badge -
Link CONTRIBUTING.md to README
I also created a few pull requests (including in the paper). There, another suggestion is for you to give an example in the introduction when you say: "... programme according to some pre-determined criteria (e. g. ...)".
Lastly, after reading the documentation, this part referring to the NDD and D' was unclear to me (maybe because I am too far from this theoretical field). Screenshot below:
And I think this is all for now from my side!
Edited by Ariane Sasso