Skip to content

[creditmutuel] Implement initial DIGIPASS support.

Cyril Brulebois requested to merge cyrilbrulebois/woob:creditmutuel-digipass-support-v3 into master

Quoting the main commit:

It might make sense to have some callback to close the image being
showed for user to scan, but let's keep things simple for now. After
all, the need to re-scan should only pop up every few months (depending
on the type of account, and on its configuration).

Changes in v2:
 - browser: Use a minimum viable implementation, and wait for bug
   reports to come in before trying to address use cases triggering
   errors.
 - pages: Use AssertionError instead of BrowserUnavailable when the
   image is not detected at all, or detected but not encoded as
   expected.
 - pages: Rewrite error messages in French.
 - pages: Make DigipassPage inherit from OtpValidationPage (only) to
   avoid code duplication (get_otp_data in particular), as it seems
   DIGIPASS-based OTP and SMS-based OTP are very similar.

Changes in v3:
 - browser: Trigger an AssertionError if OTP data is missing.

This is an updated version of !587 (closed), with the last change (in v3) being the only one not having been reviewed/commented on yet, rebased on most recent master. In passing, f501f1fa (from !590 (merged)) is indeed confirmed to make !588 (closed) obsolete.

Test-wise: I've dropped localconfig/bank.storage again, and verified that I can use the DIGIPASS device to reconnect on both my personal and professional accounts at CIC.

Merge request reports