icmp.ident - separate combined column for be/le
## Summary
OSQA (old Q&A site) - [Some questions about ICMP dissection](https://osqa-ask.wireshark.org/questions/60779/some-questions-about-icmp-dissection)
Version 2.2.5 (v2.2.5-0-g440fd4d)
icmp.ident Identifier (BE) Unsigned integer, 2 bytes 1.0.0 to 2.2.5
icmp.seq Sequence number (BE) Unsigned integer, 2 bytes 1.0.0 to 2.2.5
icmp.seq_le Sequence number (LE) Unsigned integer, 2 bytes 1.4.0 to 2.2.5
1. When added as a column: icmp.seq and icmp.seq_le display two bytes and only one copy (be/le) which is properly formatted.
icmp.ident displays both be and le in the same column
2. None of them seem to sort properly when column header clicked in 2.2.5
3. Is the ICMP dissector in a dll/binary or is there an ASCII file with its config?
Item 3 - What is [packet-icmp.c](https://gitlab.com/wireshark/wireshark/-/blob/master/epan/dissectors/packet-icmp.c) for $500 Alex ?
Item 2 - fixed here? - [Numeric Field values defined with BASE_UNIT_STRING do not sort numerically](https://gitlab.com/wireshark/wireshark/-/issues/13827) - commits to [master-2.4 and master](https://code.wireshark.org/review/#/q/%22+Qt:+try+harder+to+sort%22)
Confirmed with downloads from [all-versions](https://1.na.dl.wireshark.org/win32/all-versions/) that sorting works in 2.4.0 but not 2.2.17.
Item 1 - submitting !1082 to fix typo in `hf_icmp_ident_le` field definition
Original code added here: [Clean up the icmp info column per discussion in bug #4014.](https://gitlab.com/wireshark/wireshark/-/commit/0583c64d8f51575502b519e3b854b0383cad3a48)
Clean up the icmp info column per discussion in bug #4014.
Change to using new ENC_[BIG|LITTLE]_ENDIAN instead of FALSE and TRUE
in the proto_tree_add_item() calls for the identifier and sequence numbers.
https://gitlab.com/wireshark/wireshark/-/issues/4014
ICMP: Add ID and seq # to Info column
----------------------------
Original question.
Thanks to Chris for the detailed answer - was a bit over my head at that time.
And to @rknall for encouraging me at sf19us to open a bugzilla case.
A mere 18 months (or 3-1/2 years depending on how you count) I'm fixing it myself. :-)
issue