Potential mis-match in GSM MAP dissector for uncertainty radius and its filter key
Summary
The dissector for geographic shape information in packet-gsm_a_common.c has a (significant) mismatch between the displayed text in the Packet Details view, and the filtering key, for "Uncertainty Radius" values.
Uncertainty radius values are shown with the text "Uncertainty radius: x", but the filtering key is gsm_a.gad.no_of_points
.
I think this may be caused by the following section of code, where gsm_a.gad.no_of_points
is associated with Uncertainty radius: Line 4753 of packet-gsm_a_common.c
{ &hf_gsm_a_geo_loc_uncertainty_radius,
{ "Uncertainty radius", "gsm_a.gad.no_of_points",
FT_UINT8, BASE_DEC, NULL, 0x7f,
NULL, HFILL }
},
Earlier in the file, there is another association between where gsm_a.gad.no_of_points
is associated correctly: Line 4669 of packet-gsm_a_common.ce:
{ &hf_gsm_a_geo_loc_no_of_points,
{ "Number of points", "gsm_a.gad.no_of_points",
FT_UINT8, BASE_DEC, NULL, 0x0f,
NULL, HFILL }
},
Steps to reproduce
- View a packet containing geographic information encoded with 3GPP TS 23.032.
What is the current bug behavior?
Uncertainty radius values are shown with the text "Uncertainty radius: x", but the filtering key is gsm_a.gad.no_of_points
.
What is the expected correct behavior?
The filtering key should be more reasonably associated with the value's meaning. e.g. possibly: gsm_a.gad.uncertainty_radius
, which would be consistent with other values:
Sample capture file
Unfortunately, I observed this problem at work and cannot easily produce a sample capture file without private information.
Build information
Version 4.2.0 (v4.2.0-0-g54eedfc63953).
Compiled (64-bit) using Microsoft Visual Studio 2022 (VC++ 14.37, build 32822),
with GLib 2.78.0, with Qt 6.5.3, with libpcap, with zlib 1.3.0, with PCRE2, with
Lua 5.2.4 (with UfW patches), with GnuTLS 3.7.9 and PKCS #11 support, with
Gcrypt 1.10.2-unknown, with Kerberos (MIT), with MaxMind, with nghttp2 1.57.0,
with nghttp3 1.0.0, with brotli, with LZ4, with Zstandard, with Snappy, with
libxml2 2.11.5, with libsmi 0.5.0, with QtMultimedia, with automatic updates
using WinSparkle 0.8.0, with AirPcap, with Minizip, with binary plugins.
Running on 64-bit Windows 11 (22H2), build 22621, with Intel(R) Core(TM)
i7-8850H CPU @ 2.60GHz (with SSE4.2), with 65341 MB of physical memory, with
GLib 2.78.0, with Qt 6.5.3, with Npcap version 1.78, based on libpcap version
1.10.4, with PCRE2 10.42 2022-12-11, with c-ares 1.19.0, with GnuTLS 3.7.9, with
Gcrypt 1.10.2-unknown, with nghttp2 1.57.0, with nghttp3 1.0.0, with brotli
1.0.9, with LZ4 1.9.3, with Zstandard 1.5.2, without AirPcap, with dark display
mode, without HiDPI, with QPA plugin "windows", with LC_TYPE=English_New
Zealand.utf8, binary plugins supported.