Skip to content

Building against c-ares 1.34 fails

Summary

Building against c-ares 1.34 fails. The issue is that c-ares has changed the ARES_VERSION_STR define in ares_version.h (see https://github.com/c-ares/c-ares/commit/ec67acaa3de9a1f7d66f9a5a5e932f24613699fb#diff-1b32da9bc30f55099e244a82f4b09de920cb82af707a061149b2166112632e2cL39), so the version detection in cmake/modules/FindCARES.cmake fails.

Steps to reproduce

Try building against c-ares 1.34 or later.

What is the current bug behavior?

A build failure:

CMake Error at ../cmake-3.30.4/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):

  Could NOT find CARES: (Required is at least version "1.13.0") (found

  /path/to/libcares.so)

Call Stack (most recent call first):

  ../cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:601 (_FPHSA_FAILURE_MESSAGE)

  cmake/modules/FindCARES.cmake:49 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)

  CMakeLists.txt:1251 (find_package)

What is the expected correct behavior?

The build should succeed.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information